feat: いい感じ変換の設定をMagic Conversionウィンドウに統合 #265
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View Move all いい感じ変換 (Magic Conversion) settings to the prompt input window: - Add settings button (gear icon) to Magic Conversion window header - Create MagicConversionSettingsSheet with keyboard shortcut, AI backend, and OpenAI API settings - Remove いい感じ変換 section from ConfigWindow basic tab - Remove 基本ショートカット section from ConfigWindow customize tab - Clean up unused variables and functions from ConfigWindow Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ortcuts-in-pin-ui
Keep AI backend settings in ConfigWindow for easier access, while shortcuts remain configurable in PromptInputView. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove debug logger and timing measurements from InputController - Add early return optimization for custom prompt shortcut check - Remove "Created by Claude Code" file headers Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ortcuts-in-pin-ui # Conflicts: # azooKeyMac/InputController/azooKeyMacInputController.swift
Co-Authored-By: Claude Opus 4.5 <[email protected]>
…ortcuts-in-pin-ui
- Remove debug print statements from KeyboardShortcutConfigItem - Remove debug messages from custom shortcut handling - Add custom decoder to PromptHistoryItem for backward compatibility with existing data Co-Authored-By: Claude Opus 4.5 <[email protected]>
ensan-hcl
reviewed
Jan 15, 2026
Member
There was a problem hiding this comment.
このファイルなんだけど、Apple Platform非依存のロジックに関してはCore/側で管理していきたいので、NSEvent部分以外を上手くCore/の方に書いてほしい。
ensan-hcl
reviewed
Jan 15, 2026
| @@ -0,0 +1,74 @@ | |||
| @_spi(Core) import Core | |||
ensan-hcl
reviewed
Jan 15, 2026
Member
There was a problem hiding this comment.
このファイルも同じ理由で、実装可能な部分はなるべくCore/側に置いてほしい。今はほとんどのConfigはCore/側に移動してる。
ensan-hcl
reviewed
Jan 15, 2026
| import Cocoa | ||
|
|
||
| /// キーボードショートカットを表す構造体 | ||
| public struct KeyboardShortcut: Codable, Equatable, Hashable, Sendable { |
Member
There was a problem hiding this comment.
KeyboardShotrcut側にeisuDoubleTapとkanaDoubleTapを入れる案はない？
Collaborator
Author
There was a problem hiding this comment.
入れてもいいんだけど将来的になんか困りそうじゃない？そうでもないか？
ensan-hcl
reviewed
Jan 15, 2026
| return | ||
| } | ||
|
|
||
| if event.keyCode == 53 { |
Member
There was a problem hiding this comment.
この辺のキーコード、キーコードで書いてあってもパッと分からないのでコメントを書いて欲しい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
変更内容
Magic Conversionウィンドウ
ConfigWindow
コード整理
CustomPromptShortcut構造体とCustomPromptShortcutsEditor.swiftを削除PromptHistoryItemに直接保存するように変更テスト項目
🤖 Generated with Claude Code